Skip to content

Make ProjectId#isValidFormatId public #125134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2025
Merged

Make ProjectId#isValidFormatId public #125134

merged 3 commits into from
Mar 20, 2025

Conversation

@pxsalehi
Copy link
Member

@pxsalehi pxsalehi commented Mar 18, 2025 •
edited
Loading

No description provided.

@pxsalehi pxsalehi added the :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. label Mar 18, 2025
@elasticsearchmachine elasticsearchmachine added v9.1.0 serverless-linked Added by automation, don't add manually labels Mar 18, 2025
@pxsalehi pxsalehi requested review from jfreden and ywangd March 19, 2025 14:37
@pxsalehi pxsalehi added :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) and removed :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. labels Mar 19, 2025
@pxsalehi
Copy link
Member Author

pxsalehi commented Mar 19, 2025

We probably need a catch all label for distrib coordination or multiproject.

@pxsalehi pxsalehi marked this pull request as ready for review March 19, 2025 14:39
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Mar 19, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 19, 2025

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

ywangd
ywangd approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pxsalehi pxsalehi removed the serverless-linked Added by automation, don't add manually label Mar 20, 2025
@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Mar 20, 2025
@pxsalehi pxsalehi merged commit 11e4d31 into elastic:main Mar 20, 2025
18 checks passed
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Mar 21, 2025
@pxsalehi @afoucret
Make ProjectId#isValidFormatId public (elastic#125134)
278ef28
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Mar 21, 2025
@pxsalehi @smalyshev
Make ProjectId#isValidFormatId public (elastic#125134)
74d3c09
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
@pxsalehi @omricohenn
Make ProjectId#isValidFormatId public (elastic#125134)
6ed0d63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywangd ywangd ywangd approved these changes

@jfreden jfreden jfreden approved these changes

Assignees

No one assigned

Labels

:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >non-issue serverless-linked Added by automation, don't add manually Team:Distributed Coordination Meta label for Distributed Coordination team v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pxsalehi @elasticsearchmachine @ywangd @jfreden