Skip to content

[ML] Record errors relating to the output of a model as conflict #125135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

[ML] Record errors relating to the output of a model as conflict #125135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
690bfb9
Record errors from models as conflict
davidkyle Mar 18, 2025
65a282d
Merge branch 'main' into model-error
prwhelan Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ml/src/main/java/org/elasticsearch/xpack/ml/inference/nlp/QuestionAnsweringProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public InferenceResults processResult(TokenizationResult tokenization, PyTorchIn
if (pyTorchResult.getInferenceResult().length % 2 != 0) {
throw new ElasticsearchStatusException(
"question answering result has invalid dimension, number of dimensions must be a multiple of 2 found [{}]",
RestStatus.INTERNAL_SERVER_ERROR,
RestStatus.CONFLICT,
pyTorchResult.getInferenceResult().length
);
}
Expand All @@ -138,7 +138,7 @@ public InferenceResults processResult(TokenizationResult tokenization, PyTorchIn
if (numberOfSpans != tokensList.size()) {
throw new ElasticsearchStatusException(
"question answering result has invalid dimensions; the number of spans [{}] does not match batched token size [{}]",
RestStatus.INTERNAL_SERVER_ERROR,
RestStatus.CONFLICT,
numberOfSpans,
tokensList.size()
);
Expand All @@ -153,7 +153,7 @@ public InferenceResults processResult(TokenizationResult tokenization, PyTorchIn
if (starts.length != ends.length) {
throw new ElasticsearchStatusException(
"question answering result has invalid dimensions; start positions [{}] must equal potential end [{}]",
RestStatus.INTERNAL_SERVER_ERROR,
RestStatus.CONFLICT,
starts.length,
ends.length
);
Expand Down Expand Up @@ -222,7 +222,7 @@ static void topScores(
if (start.length != end.length) {
throw new ElasticsearchStatusException(
"question answering result has invalid dimensions; possible start tokens [{}] must equal possible end tokens [{}]",
RestStatus.INTERNAL_SERVER_ERROR,
RestStatus.CONFLICT,
start.length,
end.length
);
Expand Down
4 changes: 2 additions & 2 deletions ...l/src/main/java/org/elasticsearch/xpack/ml/inference/nlp/TextClassificationProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ static InferenceResults processResult(
if (result.length != labels.size()) {
throw new ElasticsearchStatusException(
"Expected exactly [{}] values in text classification result; got [{}]",
RestStatus.INTERNAL_SERVER_ERROR,
RestStatus.CONFLICT,
labels.size(),
result.length
);
Expand All @@ -108,7 +108,7 @@ static InferenceResults processResult(
Map<Integer, List<TokenizationResult.Tokens>> windowedSeq = tokenization.getTokensBySequenceId();
// TODO adjust logic when batch is allowed
if (windowedSeq.size() > 1) {
throw new ElasticsearchStatusException("Unexpected batch input for text classification", RestStatus.INTERNAL_SERVER_ERROR);
throw new ElasticsearchStatusException("Unexpected batch input for text classification", RestStatus.CONFLICT);
}
double[] normalizedScores = new double[labels.size()];
for (int i = 0; i < pyTorchResult.getInferenceResult()[0].length; i++) {
Expand Down
2 changes: 1 addition & 1 deletion ...in/ml/src/main/java/org/elasticsearch/xpack/ml/inference/nlp/TextSimilarityProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public InferenceResults processResult(TokenizationResult tokenization, PyTorchIn
if (result.length != 1) {
throw new ElasticsearchStatusException(
"Expected exactly [1] value in text_similarity result; got [{}]",
RestStatus.INTERNAL_SERVER_ERROR,
RestStatus.CONFLICT,
result.length
);
}
Expand Down
6 changes: 3 additions & 3 deletions ...c/main/java/org/elasticsearch/xpack/ml/inference/nlp/ZeroShotClassificationProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public InferenceResults processResult(TokenizationResult tokenization, PyTorchIn
if (pyTorchResult.getInferenceResult()[0].length != labels.length) {
throw new ElasticsearchStatusException(
"Expected exactly [{}] values in zero shot classification result; got [{}]",
RestStatus.INTERNAL_SERVER_ERROR,
RestStatus.CONFLICT,
labels.length,
pyTorchResult.getInferenceResult().length
);
Expand All @@ -160,7 +160,7 @@ public InferenceResults processResult(TokenizationResult tokenization, PyTorchIn
if (vals.length != 3) {
throw new ElasticsearchStatusException(
"Expected exactly [{}] values in inner zero shot classification result; got [{}]",
RestStatus.INTERNAL_SERVER_ERROR,
RestStatus.CONFLICT,
3,
vals.length
);
Expand All @@ -177,7 +177,7 @@ public InferenceResults processResult(TokenizationResult tokenization, PyTorchIn
if (vals.length != 3) {
throw new ElasticsearchStatusException(
"Expected exactly [{}] values in inner zero shot classification result; got [{}]",
RestStatus.INTERNAL_SERVER_ERROR,
RestStatus.CONFLICT,
3,
vals.length
);
Expand Down