Do not look over TaskCancelledException when looking at failures when updating CCS info for clusters
#125206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawankartik-elastic
added
>enhancement
>test
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
quux00
reviewed
Mar 19, 2025
| } | ||
|
|
||
| private static boolean isTaskCancelledException(Exception e) { | ||
| static boolean isTaskCancelledException(Exception e) { |
There was a problem hiding this comment.
I would say, let's move this method to ExceptionsHelper itself, since we need to call it in more than one place. It's a little awkward for TransportSearchAction to depend on methods in AbstractSearchAsyncAction.
quux00
approved these changes
Mar 19, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
pawankartik-elastic
added a commit
to pawankartik-elastic/elasticsearch
that referenced
this pull request
Mar 19, 2025
…en updating CCS info for clusters (elastic#125206) Do not look over `TaskCancelledException` when looking at failures when updating CCS info for clusters
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
pawankartik-elastic
added a commit
to pawankartik-elastic/elasticsearch
that referenced
this pull request
Mar 19, 2025
…en updating CCS info for clusters (elastic#125206) Do not look over `TaskCancelledException` when looking at failures when updating CCS info for clusters (cherry picked from commit 0350a48) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 19, 2025
…res when updating CCS info for clusters (#125206) (#125237) * Do not look over `TaskCancelledException` when looking at failures when updating CCS info for clusters (#125206) Do not look over `TaskCancelledException` when looking at failures when updating CCS info for clusters (cherry picked from commit 0350a48) # Conflicts: # muted-tests.yml * Fix conflict
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
…en updating CCS info for clusters (elastic#125206) Do not look over `TaskCancelledException` when looking at failures when updating CCS info for clusters
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…en updating CCS info for clusters (elastic#125206) Do not look over `TaskCancelledException` when looking at failures when updating CCS info for clusters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using
skipUnavailablewhen looking at failures. However, we should not be looking overTaskCancelledExceptionand more importantly, not wrap it. Fixes #108061.