[Entitlements] Replace Permissions with Entitlements in InstallPluginAction #125207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
auto-backport
ldematte
commented
Mar 19, 2025
distribution/tools/plugin-cli/src/main/java/org/elasticsearch/plugins/cli/PluginSecurity.java
Show resolved
Hide resolved
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Mar 22, 2025
distribution/tools/plugin-cli/src/main/java/org/elasticsearch/plugins/cli/PluginSecurity.java
Outdated
Show resolved
Hide resolved
| @@ -1,5 +0,0 @@ | |||
| org.elasticsearch.analysis.icu: | |||
Member
There was a problem hiding this comment.
This is unrelated, right? Let's do this in a separate PR. I'm still not sure we should, we could leave this in as we try to re-lock-down the config directory.
Contributor
Author
There was a problem hiding this comment.
I did this because this is breaking tests downstream - packaging tests are installing a plugin that has no additional permission so it can happen non-interactively, ant this was the plugin of choice. I can revert this but will need to change more tests downstream, not sure what's better here.
prdoyle
reviewed
Mar 24, 2025
distribution/tools/plugin-cli/src/main/java/org/elasticsearch/plugins/cli/PluginSecurity.java
Outdated
Show resolved
Hide resolved
libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/PolicyUtils.java
Show resolved
Hide resolved
…l-plugin-confirmation
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Apr 2, 2025
…Action (elastic#125207) This PR replaces the parsing and formatting of SecurityManager policies with the parsing and formatting of Entitlements policy during plugin installation. Relates to ES-10923
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Apr 2, 2025
…Action (elastic#125207) This PR replaces the parsing and formatting of SecurityManager policies with the parsing and formatting of Entitlements policy during plugin installation. Relates to ES-10923
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Apr 2, 2025
…Action (elastic#125207) This PR replaces the parsing and formatting of SecurityManager policies with the parsing and formatting of Entitlements policy during plugin installation. Relates to ES-10923
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
…Action (elastic#125207) This PR replaces the parsing and formatting of SecurityManager policies with the parsing and formatting of Entitlements policy during plugin installation. Relates to ES-10923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the parsing and formatting of SecurityManager policies with the parsing and formatting of Entitlements policy during plugin installation.
Relates to ES-10923