ES|QL: Add license check for RRF #125225
Merged
ES|QL: Add license check for RRF #125225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanatia
added
>non-issue
:Analytics/ES|QL
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
ioanatia
commented
Mar 19, 2025
| } | ||
| } | ||
|
|
||
| public void testRrf() { |
There was a problem hiding this comment.
this test failed because we don't load the EsqlPluginWithEnterpriseOrTrialLicense test plugin.
I did not see a need to load this plugin for the FORK tests so I took this test out in its own RrfIT since it was primarily aimed at testing RRF and not FORK.
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Mar 21, 2025
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in #123391
Adds a license check for RRF - RRF is an enterprise level feature for the search DSL and for ES|QL we need to preserve the license level.
I also had to take out a RRF test from
ForkITbecause it was now failing because of the license check.It's probably cleaner this way to have a dedicated
RrfITinstead of reusingForkIT.