[Failure Store] Prevent usage of :: selectors with cross-cluster expressions #125252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slobodanadamovic
added
>non-issue
:Security/Security
slobodanadamovic
changed the title
|
Pinging @elastic/es-security (Team:Security) |
|
Pinging @elastic/es-data-management (Team:Data Management) |
…nt-using-selectors-for-ccs-ccr
…nt-using-selectors-for-ccs-ccr
…nt-using-selectors-for-ccs-ccr
Yeah, RCS1 is special in sense that users can define roles which grants direct access to failure store indices and search them - there is no way for us to prevent that (nor should we). I think this is fine in the short term, since we do want to support CCS in the long term. |
|
FIPS failures are unrelated. Fix incoming: #125754 |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Mar 28, 2025
…essions (elastic#125252) The CCS is currently not supported for failure store backing indices. This PR adjusts the selector parsing (introduced in elastic#118614) to prevent using `::failures` and `::data` selectors with cross-cluster expressions. For example, `GET my_remote_cluster:logs-*::failures/_search` request will fail early, during expression parsing. To test manually, run `./gradlew run-ccs` and execute the example request. (cherry picked from commit 1d6c6a5) # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/IndexNameExpressionResolver.java # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/StatementParserTests.java
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…essions (elastic#125252) The CCS is currently not supported for failure store backing indices. This PR adjusts the selector parsing (introduced in elastic#118614) to prevent using `::failures` and `::data` selectors with cross-cluster expressions. For example, `GET my_remote_cluster:logs-*::failures/_search` request will fail early, during expression parsing. To test manually, run `./gradlew run-ccs` and execute the example request.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 31, 2025
…r expressions (#125252) (#125831) * [Failure Store] Prevent usage of :: selectors with cross-cluster expressions (#125252) The CCS is currently not supported for failure store backing indices. This PR adjusts the selector parsing (introduced in #118614) to prevent using `::failures` and `::data` selectors with cross-cluster expressions. For example, `GET my_remote_cluster:logs-*::failures/_search` request will fail early, during expression parsing. To test manually, run `./gradlew run-ccs` and execute the example request. (cherry picked from commit 1d6c6a5) # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/IndexNameExpressionResolver.java # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/StatementParserTests.java * backport also test assertion fix
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Mar 31, 2025
This PR prevents using `::` selectors in remote index expressions and adds a basing integration test with security off Relates to elastic#125252
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Mar 31, 2025
This PR prevents using `::` selectors in remote index expressions and adds a basing integration test with security off Relates to elastic#125252
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Apr 1, 2025
…ff (elastic#125968) This PR prevents using `::` selectors in remote index expressions and adds a basic integration test with security off. Relates to elastic#125252 (cherry picked from commit 83d7fe0) # Conflicts: # server/src/main/java/org/elasticsearch/action/ResolvedIndices.java
slobodanadamovic
added a commit
that referenced
this pull request
Apr 9, 2025
Adjust existing RCS1 tests to randomize using API keys for authorization and `skip_unavailable` setting. Followup on #125252
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Apr 9, 2025
…#125782) Adjust existing RCS1 tests to randomize using API keys for authorization and `skip_unavailable` setting. Followup on elastic#125252
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CCS is currently not supported for failure store backing indices. This PR adjusts the selector parsing (introduced in #118614) to prevent using
::failuresand::dataselectors with cross-cluster expressions.For example,
GET my_remote_cluster:logs-*::failures/_searchrequest will fail early, during expression parsing.To test manually, run
./gradlew run-ccsand execute the example request.