Skip to content

[Entitlements] Print a warning during plugin installation if a legacy policy file is found #125294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

[Entitlements] Print a warning during plugin installation if a legacy policy file is found #125294

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d76fe4
Add warning if a legacy policy file is found
ldematte Mar 20, 2025
caa0d59
[CI] Auto commit changes from spotless
Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...ion/tools/plugin-cli/src/main/java/org/elasticsearch/plugins/cli/InstallPluginAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,6 +923,14 @@ void jarHellCheck(PluginDescriptor candidateInfo, Path candidateDir, Path plugin
*/
private PluginDescriptor installPlugin(InstallablePlugin descriptor, Path tmpRoot, List<Path> deleteOnFailure) throws Exception {
final PluginDescriptor info = loadPluginInfo(tmpRoot);

Path legacyPolicyFile = tmpRoot.resolve(PluginDescriptor.ES_PLUGIN_POLICY);
if (Files.exists(legacyPolicyFile)) {
terminal.errorPrintln("WARNING: this plugin contains a legacy Security Policy file. Starting with version 8.18, " +
"Entitlements replace SecurityManager as the security mechanism. Plugins must migrate their policy files to the new " +
"format. For more information, please refer to " + PluginSecurity.ENTITLEMENTS_DESCRIPTION_URL);
}

if (RuntimeVersionFeature.isSecurityManagerAvailable()) {
PluginPolicyInfo pluginPolicy = PolicyUtil.getPluginPolicyInfo(tmpRoot, env.tmpDir());
if (pluginPolicy != null) {
Expand Down
3 changes: 3 additions & 0 deletions ...ribution/tools/plugin-cli/src/main/java/org/elasticsearch/plugins/cli/PluginSecurity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@
*/
public class PluginSecurity {

public static final String ENTITLEMENTS_DESCRIPTION_URL =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicated in #125207, but should be easy to merge later

"https://www.elastic.co/guide/en/elasticsearch/plugins/current/creating-classic-plugins.html";

/**
* prints/confirms policy exceptions with the user
*/
Expand Down