Don't immediately scale down startups triggered by non-master nodes in inference adaptive allocations. #125297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n inference adaptive allocations.
jan-elastic
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
approved these changes
Mar 20, 2025
| return Void.TYPE; | ||
| }).when(client).execute(eq(GetDeploymentStatsAction.INSTANCE), eq(new GetDeploymentStatsAction.Request("test-deployment")), any()); | ||
|
|
||
| safeSleep(1200); |
There was a problem hiding this comment.
Is this waiting for the doAnswer() call? I'm not sure if this will be flaky but another option could be to add a count down latch and then here we await for the latch to be decremented.
There was a problem hiding this comment.
This is waiting for the adaptive allocations background process that makes these calls. That runs every 1s in this test (see constructor above). If within 1200ms nothing has happened, something is wrong.
With 200ms leeway it shouldn't be flaky, and never has been in the past.
I've also run these tests 100x locally without any problems.
jan-elastic
deleted the
adaptive-allocations-dont-scaledown-recent-startups
branch
jan-elastic
added a commit
that referenced
this pull request
Mar 21, 2025
…n inference adaptive allocations. (#125297)
This was referenced Mar 21, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Mar 21, 2025
…n inference adaptive allocations. (elastic#125297)
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
…n inference adaptive allocations. (elastic#125297)
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…n inference adaptive allocations. (elastic#125297)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.