-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Make project and cluster secrets customs available in server #125406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-security (Team:Security) |
|
Hi @jfreden, I've created a changelog YAML for you. |
|
I think this PR should be a non-issue since none of the classes is used in Stateful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this won't work for repository plugins since they do not have access to x-pack code and I don't think we want make them depend on it either. The classes will have to be part of the server package for broader access.
Also, I personally think it's fine to move these classes between repos. But it would be great to get confirmation from @tvernum since it incurs license changes.
|
Good catch @ywangd ! I've moved them to server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a ClusterStateSecretsMetadataTests file that can potentially be moved over as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind. I just realized this is for a different class ClusterStateSecretsMetadata. It is a bit strange though that the secrets and the its metadata are now in separate repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you didn't move ClusterStateSecretsMetadata because it is something only the managing service cares about. Also, if we migrate cluster secrets to be managed by file setting service, the metadata class is no longer necessary since file setting service manages its own set of metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this. Yes, that's what I was thinking. The reserved cluster state service will handle all that for us.
…#125406) * Make project and cluster secrets customs available in core
This PR adds
ClusterStateSecretsandProjectSecrets(renamed toClusterSecretsandProjectSecrets).The reason for moving these into core is to allow plugins to deserialize project and cluster secrets in cluster state as opposed to relying on reloadable plugin to do so. This enables features to read secrets from the same cluster state update as project creation.