ESQL: Document warnings behavior in CsvTests #125441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `CsvTests` has a slight difference regarding warnings from real Elasticsearch indices and this is worth documenting. I've also added an explanation to `SingleValueMatchQuery` that explains *exactly* when it makes a warning because it's not *exactly* the same as when the compute engine would make a warning. The resulting documents are the same - but the warnings are not.
nik9000
added
>non-issue
auto-backport
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
approved these changes
Mar 24, 2025
This was referenced Mar 24, 2025
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 24, 2025
The `CsvTests` has a slight difference regarding warnings from real Elasticsearch indices and this is worth documenting. I've also added an explanation to `SingleValueMatchQuery` that explains *exactly* when it makes a warning because it's not *exactly* the same as when the compute engine would make a warning. The resulting documents are the same - but the warnings are not.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 24, 2025
The `CsvTests` has a slight difference regarding warnings from real Elasticsearch indices and this is worth documenting. I've also added an explanation to `SingleValueMatchQuery` that explains *exactly* when it makes a warning because it's not *exactly* the same as when the compute engine would make a warning. The resulting documents are the same - but the warnings are not.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 24, 2025
The `CsvTests` has a slight difference regarding warnings from real Elasticsearch indices and this is worth documenting. I've also added an explanation to `SingleValueMatchQuery` that explains *exactly* when it makes a warning because it's not *exactly* the same as when the compute engine would make a warning. The resulting documents are the same - but the warnings are not.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 24, 2025
The `CsvTests` has a slight difference regarding warnings from real Elasticsearch indices and this is worth documenting. I've also added an explanation to `SingleValueMatchQuery` that explains *exactly* when it makes a warning because it's not *exactly* the same as when the compute engine would make a warning. The resulting documents are the same - but the warnings are not.
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
The `CsvTests` has a slight difference regarding warnings from real Elasticsearch indices and this is worth documenting. I've also added an explanation to `SingleValueMatchQuery` that explains *exactly* when it makes a warning because it's not *exactly* the same as when the compute engine would make a warning. The resulting documents are the same - but the warnings are not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CsvTestshas a slight difference regarding warnings from real Elasticsearch indices and this is worth documenting. I've also added an explanation toSingleValueMatchQuerythat explains exactly when it makes a warning because it's not exactly the same as when the compute engine would make a warning. The resulting documents are the same - but the warnings are not.