-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add multi-project support for health indicator shards_availability #125512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-project support for health indicator shards_availability #125512
Conversation
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @samxbr, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, but I think this is going in the right direction! Thanks for working on this, Sam.
server/src/main/java/org/elasticsearch/health/node/HealthIndicatorDisplayValues.java
Outdated
Show resolved
Hide resolved
...lasticsearch/cluster/routing/allocation/shards/ShardsAvailabilityHealthIndicatorService.java
Outdated
Show resolved
Hide resolved
...lasticsearch/cluster/routing/allocation/shards/ShardsAvailabilityHealthIndicatorService.java
Show resolved
Hide resolved
...-multiple-projects/src/yamlRestTest/resources/rest-api-spec/test/health/10_multi_project.yml
Outdated
Show resolved
Hide resolved
...-multiple-projects/src/yamlRestTest/resources/rest-api-spec/test/health/10_multi_project.yml
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/health/node/ProjectIndexName.java
Outdated
Show resolved
Hide resolved
...csearch/cluster/routing/allocation/shards/ShardsAvailabilityHealthIndicatorServiceTests.java
Outdated
Show resolved
Hide resolved
...csearch/cluster/routing/allocation/shards/ShardsAvailabilityHealthIndicatorServiceTests.java
Outdated
Show resolved
Hide resolved
...lasticsearch/cluster/routing/allocation/shards/ShardsAvailabilityHealthIndicatorService.java
Outdated
Show resolved
Hide resolved
...csearch/cluster/routing/allocation/shards/ShardsAvailabilityHealthIndicatorServiceTests.java
Outdated
Show resolved
Hide resolved
...csearch/cluster/routing/allocation/shards/ShardsAvailabilityHealthIndicatorServiceTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the iterations, Sam!
This PR makes the shards_availability health indicator for health report API project aware. If the cluster is running in a multi-project enabled cluster, the indicator result will include the
projectIdfor the affected indices if the indicator is not GREEN.