ES-10037 Track the peak indexing load for each shard #125521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeteGillinElastic
force-pushed
the
ES-10037-peak-write-load
branch
from
b96b1c3 to
36cafdc
Compare
PeteGillinElastic
added
:Data Management/Stats
PeteGillinElastic
force-pushed
the
ES-10037-peak-write-load
branch
4 times, most recently
from
bf752ef to
d2ff0cd
Compare
This tracks the highest value seen for the recent write load metric any time the stats for a shard was computed, exposes this value alongside the recent value, and persists it in index metadata alongside it too. The new test in `IndexShardTests` is designed to more thoroughly test the recent write load metric previously added, as well as to test the peak metric being added here. ES-10037
PeteGillinElastic
force-pushed
the
ES-10037-peak-write-load
branch
from
d2ff0cd to
2b2cf6d
Compare
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
dakrone
approved these changes
Mar 26, 2025
| if (shardsPeakWriteLoad != null && shardsPeakWriteLoad.size() != shardsUptimeInMillis.size()) { | ||
| assert false : "IndexWriteLoad.create() was called with non-matched lengths for shardsPeakWriteLoad and shardUptimeInMillis"; | ||
| throw new IllegalArgumentException( | ||
| "The same number of shard write loads and shard uptimes should be provided, but " |
There was a problem hiding this comment.
super minor, but should this say "peak write loads" instead of just "write loads"?
There was a problem hiding this comment.
Thanks, done (and I did the same to the 'recent' one above, which had the same issue).
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
This tracks the highest value seen for the recent write load metric any time the stats for a shard was computed, exposes this value alongside the recent value, and persists it in index metadata alongside it too. The new test in `IndexShardTests` is designed to more thoroughly test the recent write load metric previously added, as well as to test the peak metric being added here. ES-10037 #comment Added peak load metric in elastic#125521
PeteGillinElastic
added a commit
to elastic/elasticsearch-specification
that referenced
this pull request
Apr 3, 2025
This adds the fields added in elastic/elasticsearch#125521 and elastic/elasticsearch#124652 to the spec.
PeteGillinElastic
added a commit
to elastic/elasticsearch-specification
that referenced
this pull request
Apr 3, 2025
This adds the fields added in elastic/elasticsearch#125521 and elastic/elasticsearch#124652 to the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tracks the highest value seen for the recent write load metric any time the stats for a shard was computed, exposes this value alongside the recent value, and persists it in index metadata alongside it too.
The new test in
IndexShardTestsis designed to more thoroughly test the recent write load metric previously added, as well as to test the peak metric being added here.