Make rule initialization static #125590
Merged
Make rule initialization static #125590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>non-issue
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
bpintea
approved these changes
Mar 31, 2025
Correct, 1.59 of parent that seems to be planning |
alex-spies
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Thanks @idegtiarenko , this is a nice simplification and optimization.
We have some slightly stateful renaming mechanisms in some optimizer rules (whenever temporary names need to be created); I double checked and they either rely on local variables (defined in the scope of a method) or synthetic static variables, so all looks good there.
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Jun 4, 2025
(cherry picked from commit 2ce2fda)
idegtiarenko
added a commit
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogicalPlanOptimizer & LocalLogicalPlanOptimizer were surprisingly visible in the profile output around initializing their long list of rules for each request (mostly spending time around creating loggers).
They do not have a state and could be shared across sessions reducing per session initialization time and amount of objects created.
(^^ initialization is hilighted with pink and accounts for ~1.59% of cpu)