Skip to content

Speed up LuceneTopNSourceOperator #125622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 26, 2025
Merged

Speed up LuceneTopNSourceOperator #125622

merged 5 commits into from
Mar 26, 2025

Conversation

@ioanatia
Copy link
Contributor

@ioanatia ioanatia commented Mar 25, 2025 •
edited
Loading

This PR changes two things in LuceneTopNSourceOperator:

  • when scoring is used we use TOP_DOCS_WITH_SCORES instead of COMPLETE score mode
  • we stop tracking the total hits, regardless of whether scoring is used or not - when we are retrieving the top N docs we don't need to track the total number of hits

credit goes to Jim for suggesting these changes

@ioanatia ioanatia added >non-issue :Analytics/ES|QL AKA ESQL Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch :Search Relevance/Search Catch all for Search Relevance v9.1.0 labels Mar 25, 2025
jimczi
jimczi approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioanatia ioanatia marked this pull request as ready for review March 26, 2025 09:19
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 26, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@ioanatia ioanatia requested a review from nik9000 March 26, 2025 09:22
@ioanatia ioanatia merged commit ebc1353 into elastic:main Mar 26, 2025
16 of 17 checks passed
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
@ioanatia @omricohenn
Speed up LuceneTopNSourceOperator (elastic#125622)
b6ce67a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

@carlosdelest carlosdelest carlosdelest approved these changes

@jimczi jimczi jimczi approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL >non-issue :Search Relevance/Search Catch all for Search Relevance Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ioanatia @elasticsearchmachine @nik9000 @carlosdelest @jimczi