-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Avoid using doc values instance that merges on the fly when building disi bitset. #125649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when building DISI bit set. Capture which doc ids have at least one value and then encode that to disk later after values have been encoded to disk. This is an optimization mentioned in elastic#125403.
Member
Author
|
Running tsdb track without this change as baseline and with this change as contender: Cumulative merging is ~9% lower. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid iterating over
SortedNumericDocValuesthat merges on the fly when building DISI bit set. This applies when index sorting is active. Capture which doc ids have at least one value and then encode that to disk later after values have been encoded to disk.This is an optimization mentioned in #125403.