[Failure Store] Access for internal users #125660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
commented
Mar 26, 2025
| new RoleDescriptor( | ||
| UsernamesField.LAZY_ROLLOVER_ROLE, | ||
| new String[] {}, | ||
| DataStream.isFailureStoreFeatureFlagEnabled() |
There was a problem hiding this comment.
Just refactoring, no actual changes for this user.
n1v0lg
added
the
auto-backport
|
Pinging @elastic/es-security (Team:Security) |
n1v0lg
added
the
auto-merge-without-approval
💚 Backport successful
|
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
This PR grants `manage_failure_store` to the internal user `_data_stream_lifecycle` to enable life-cycle management for the failure indices of data stream, which includes rollovers using the failures selector. I'm only unit testing this but we also need to add DLM tests for the failure store with security enabled. Relates: ES-11355
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 31, 2025
This PR grants `manage_failure_store` to the internal user `_data_stream_lifecycle` to enable life-cycle management for the failure indices of data stream, which includes rollovers using the failures selector. I'm only unit testing this but we also need to add DLM tests for the failure store with security enabled. Relates: ES-11355 Co-authored-by: Slobodan Adamović <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR grants
manage_failure_storeto the internal user_data_stream_lifecycleto enable life-cycle management for the failure indices of data stream, which includes rollovers using the failures selector.I'm only unit testing this but we also need to add DLM tests for the failure store with security enabled.
Relates: ES-11355