Skip to content

[8.x] Add integration tests that verify ST_EXTENT_AGG needs a license (#125584) (#125712) #125719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 28, 2025
Merged

[8.x] Add integration tests that verify ST_EXTENT_AGG needs a license (#125584) (#125712) #125719

merged 8 commits into from
Mar 28, 2025

Conversation

@craigtaverner
Copy link
Contributor

Backports the following commits to 8.x:

@craigtaverner craigtaverner added :Analytics/ES|QL AKA ESQL :Analytics/Geo Indexing, search aggregations of geo points and shapes auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Mar 26, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Mar 26, 2025
Merged
@craigtaverner craigtaverner added auto-backport Automatically create backport pull requests when merged v8.18.1 labels Mar 27, 2025
@craigtaverner craigtaverner removed auto-backport Automatically create backport pull requests when merged v8.18.1 labels Mar 27, 2025
@craigtaverner
Copy link
Contributor Author

Closing this PR because the tests are flaky on the 8.x branch. Using -Dtests.iters=1000 gave a failure rate over 20%. They are not flaky on main, so I assume this is an issue fixed there. These tests do not need to exist on 8.x, but it would be nice for them to be there. Investigating the flakiness is out of scope for this PR, but if we decide to investigate it, it is reproducible with the right seed:

./gradlew ":x-pack:plugin:esql:internalClusterTest" --tests "org.elasticsearch.xpack.esql.spatial.SpatialExtentAggregationNoLicenseIT.testStExtentAggregationWithShapes" -Dtests.seed=712BF32772B4874C

@craigtaverner craigtaverner reopened this Mar 27, 2025
@craigtaverner
Copy link
Contributor Author

Reopened after fixing mistake with ENTERPRISE vs PLATINUM license level in #125802

@craigtaverner craigtaverner added auto-backport Automatically create backport pull requests when merged v8.18.1 labels Mar 27, 2025
@elasticsearchmachine elasticsearchmachine merged commit c72aa4c into elastic:8.x Mar 28, 2025
15 checks passed
@craigtaverner craigtaverner deleted the backport/8.x/pr-125712 branch March 28, 2025 10:26
@craigtaverner craigtaverner mentioned this pull request Mar 28, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.18

craigtaverner added a commit to craigtaverner/elasticsearch that referenced this pull request Mar 28, 2025
@craigtaverner
[8.x] Add integration tests that verify ST_EXTENT_AGG needs a license (…
b553d47 
…elastic#125584) (elastic#125712) (elastic#125719)

* Add integration tests that verify ST_EXTENT_AGG needs a license (elastic#125584) (elastic#125712)

* Fix java version problem on backport

* Use PLATINUM as license level for spatial features
elasticsearchmachine pushed a commit that referenced this pull request Mar 28, 2025
@craigtaverner
[8.x] Add integration tests that verify ST_EXTENT_AGG needs a license (…
fa0db81 
…#125584) (#125712) (#125719) (#125834)

* Add integration tests that verify ST_EXTENT_AGG needs a license (#125584) (#125712)

* Fix java version problem on backport

* Use PLATINUM as license level for spatial features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL :Analytics/Geo Indexing, search aggregations of geo points and shapes auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.1 v8.19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@craigtaverner @elasticsearchmachine