Convert :test projects to new testing framework
#125724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
commented
Mar 26, 2025
| } | ||
|
|
||
| tasks.named('yamlRestTest') { | ||
| def isSnapshot = buildParams.snapshotBuild |
There was a problem hiding this comment.
@breskeby I had to do this in a number of places, otherwise the configuration cache would throw an error
There was a problem hiding this comment.
Yeah. Onlyif is evaluated at tasks execution phase and buildparsms here is an extension. Those can not be accessed during execution phase
mark-vieira
commented
Mar 26, 2025
| map.put(LegacyRestTestBasePlugin.class, ":x-pack:qa:smoke-test-plugins-ssl"); | ||
| map.put(LegacyRestTestBasePlugin.class, ":x-pack:qa:smoke-test-security-with-mustache"); | ||
| map.put(LegacyRestTestBasePlugin.class, ":x-pack:qa:xpack-prefix-rest-compat"); | ||
| map.put(LegacyRestTestBasePlugin.class, ":modules:ingest-geoip:qa:file-based-update"); |
There was a problem hiding this comment.
I simply forgot to remove these in earlier PRs
mark-vieira
commented
Mar 26, 2025
| .distribution(DistributionType.DEFAULT) | ||
| .module("test-error-query") | ||
| .module("x-pack-esql") | ||
| .module("x-pack-ilm") |
There was a problem hiding this comment.
esql requires ml which implicitly requires ilm. Perhaps that dependency should be explicit? 🤷
💔 Backport failed
You can use sqren/backport to manually backport by running |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 27, 2025
(cherry picked from commit e149a3e) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java # test/external-modules/error-query/build.gradle # test/external-modules/error-query/src/javaRestTest/java/org/elasticsearch/test/esql/EsqlPartialResultsIT.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 27, 2025
…25742) * Convert `:test` projects to new testing framework (#125724) (cherry picked from commit e149a3e) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java # test/external-modules/error-query/build.gradle # test/external-modules/error-query/src/javaRestTest/java/org/elasticsearch/test/esql/EsqlPartialResultsIT.java * Bump timeout
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 27, 2025
…) (elastic#125742) * Convert `:test` projects to new testing framework (elastic#125724) (cherry picked from commit e149a3e) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java # test/external-modules/error-query/build.gradle # test/external-modules/error-query/src/javaRestTest/java/org/elasticsearch/test/esql/EsqlPartialResultsIT.java * Bump timeout (cherry picked from commit 533d38d) # Conflicts: # test/external-modules/error-query/build.gradle
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 27, 2025
…) (elastic#125742) * Convert `:test` projects to new testing framework (elastic#125724) (cherry picked from commit e149a3e) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java # test/external-modules/error-query/build.gradle # test/external-modules/error-query/src/javaRestTest/java/org/elasticsearch/test/esql/EsqlPartialResultsIT.java * Bump timeout (cherry picked from commit 533d38d) # Conflicts: # test/external-modules/error-query/build.gradle
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 27, 2025
…25742) (#125791) * Convert `:test` projects to new testing framework (#125724) (cherry picked from commit e149a3e) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java # test/external-modules/error-query/build.gradle # test/external-modules/error-query/src/javaRestTest/java/org/elasticsearch/test/esql/EsqlPartialResultsIT.java * Bump timeout (cherry picked from commit 533d38d) # Conflicts: # test/external-modules/error-query/build.gradle
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 27, 2025
… (#125742) (#125790) * [9.0] Convert `:test` projects to new testing framework (#125724) (#125742) * Convert `:test` projects to new testing framework (#125724) (cherry picked from commit e149a3e) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java # test/external-modules/error-query/build.gradle # test/external-modules/error-query/src/javaRestTest/java/org/elasticsearch/test/esql/EsqlPartialResultsIT.java * Bump timeout (cherry picked from commit 533d38d) # Conflicts: # test/external-modules/error-query/build.gradle * Don't use default distribution
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the last remaining projects under
testto use the new testing framework.