Skip to content

[8.x] Generalize S3HttpHandler request matching (#125670) #125729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

[8.x] Generalize S3HttpHandler request matching (#125670) #125729

merged 1 commit into from
Mar 26, 2025

Conversation

@DaveCTurner
Copy link
Contributor

Backports the following commits to 8.x:

@DaveCTurner
Generalize S3HttpHandler request matching (elastic#125670)
258ab35 
The pattern-matching in `S3HttpHandler` is overly specific and carefully
crafted to handle the exact requests that the AWS SDK v1 makes. It turns
out that the AWS SDK v2 makes requests that are slightly different. This
commit generalizes the pattern-matching to handle both SDKs.
@DaveCTurner DaveCTurner added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed Coordination Meta label for Distributed Coordination team labels Mar 26, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Mar 26, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit 30b7f1b into elastic:8.x Mar 26, 2025
15 checks passed
@DaveCTurner DaveCTurner deleted the backport/8.x/pr-125670 branch March 26, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v8.19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DaveCTurner @elasticsearchmachine