Add validation step to quoted join query construction #125731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiera
added
>test-failure
elasticsearchmachine
added
Team:Data Management
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-data-management (Team:Data Management) |
alex-spies
added
>test
alex-spies
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Very nice PR, very helpful comments. Thanks @jbaiera !
Do we want to apply the auto-backport label before merging?
The original change hasn't been fully backported yet (was also experiencing some related CI woes) so I plan to bring these changes in with it to keep the 8.x branch healthy. |
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Mar 27, 2025
* Add validation step to quoted join query construction * Fix double validation
|
Backporting to 8.x with #125557 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 28, 2025
* Support index pattern selector syntax in ES|QL (#120660) This PR updates the ES|QL grammar to include the selector portion of an index pattern. Patterns are recombined before being sent to field caps. Field caps already supports this functionality, so this is primarily wiring it up where needed. * Add validation step to quoted join query construction (#125731) * Add validation step to quoted join query construction * Fix double validation * Add lexer entry for METRICS commands * Simplifying test case * regen
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
* Add validation step to quoted join query construction * Fix double validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unmutes statement parser tests and fixes some errors in the test cases to get CI running smoothly again. Added more comments to the test cases to explain why we forcefully quote and unquote the random patterns, and also for why we manually modify the random patterns returned in some parts of the test.
Also adds further validation to join query construction logic to bar selectors from being provided in quoted index patterns. Splits test validation for the right side of the join statement into two cases, a quoted one and an unquoted one.
fixes #125536