Support port 0 in community_id processor #125733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The community_id processor should support port 0 for source and destination. Although port 0 is usually reserved, it is a valid port number. Users of this processor have had errors when using port 0 with this processor. There is also no similar restriction in the original Community ID implementation. This updates the processor to support port 0 in source and destination.
elasticsearchmachine
added
v9.1.0
needs:triage
In parseIntFromObjectOrString, if the provided object is null, convert it to -1, an invalid port number.
…ch into fix_community_id_port
bhapas
added
the
:Data Management/Ingest Node
elasticsearchmachine
added
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
removed
the
needs:triage
elasticsearchmachine
removed
the
needs:triage
joegallo
added
v8.19.0
auto-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The community_id processor should support port 0 for source and destination.
Although port 0 is usually reserved, it is a valid port number. Users of this processor have had errors when using port 0 with this processor. There is also no similar restriction in the original Community ID implementation.
This updates the processor to support port 0 in source and destination.