Migrate x-pack core module to new testing framework #125740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
commented
Mar 27, 2025
| requiresFeature 'es.failure_store_feature_flag_enabled', Version.fromString("8.15.0") | ||
| systemProperty 'es.queryable_built_in_roles_enabled', 'false' | ||
| tasks.named("javaRestTest") { | ||
| usesDefaultDistribution("uses the _xpack api") |
There was a problem hiding this comment.
From what I can tell this tries to resolve pretty much every x-pack module so I gave up on going down this rabbit hole. Fortunately, these tests suites are pretty light weight so it's not a big deal.
breskeby
approved these changes
Mar 27, 2025
# Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 27, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 27, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 28, 2025
(cherry picked from commit 0c50403)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 28, 2025
(cherry picked from commit 0c50403)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 28, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 28, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts
:x-pack:plugin:coreto new testing framework.