Skip to content

[ML] Fix ModelRegistryMetadataTests #125756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2025
Merged

[ML] Fix ModelRegistryMetadataTests #125756

merged 2 commits into from
Mar 28, 2025

Conversation

@davidkyle
Copy link
Member

@davidkyle davidkyle commented Mar 27, 2025 •
edited
Loading

The tests failed rarely because sometimes when an upgraded ModelRegistryMetadata was expected the not-upgraded empty instance was returned.

Closes #125554
Closes #125585
Closes #125516

@davidkyle davidkyle added >test Issues or PRs that are addressing/adding tests :ml Machine learning auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels Mar 27, 2025
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Mar 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@davidkyle davidkyle requested a review from jimczi March 28, 2025 07:19
jimczi
jimczi approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davidkyle davidkyle enabled auto-merge (squash) March 28, 2025 10:56
@davidkyle davidkyle merged commit 67798dd into elastic:main Mar 28, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125756

davidkyle added a commit to davidkyle/elasticsearch that referenced this pull request Mar 28, 2025
@davidkyle
[ML] Fix ModelRegistryMetadataTests (elastic#125756)
c866656 
(cherry picked from commit 67798dd)

# Conflicts:
#	muted-tests.yml
@davidkyle davidkyle mentioned this pull request Mar 28, 2025
Merged
@davidkyle
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Mar 28, 2025
@davidkyle
[ML] Fix ModelRegistryMetadataTests (#125756) (#125861)
6c851ef 
(cherry picked from commit 67798dd)

# Conflicts:
#	muted-tests.yml
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
@davidkyle @omricohenn
[ML] Fix ModelRegistryMetadataTests (elastic#125756)
49bf0b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimczi jimczi jimczi approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending :ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

3 participants

@davidkyle @elasticsearchmachine @jimczi