Try fixing mutedTest.yml file not found #125763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid eager task creation introduced lately that seems to trigger some wrong behaviour here. Also use newer api for resolving root project
breskeby
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
jozala
approved these changes
Mar 27, 2025
| project.getRootProject().getPlugins().apply(GlobalBuildInfoPlugin.class); | ||
| var buildParams = loadBuildParams(project).get(); | ||
|
|
||
| File settingsRoot = project.getLayout().getSettingsDirectory().getAsFile(); |
There was a problem hiding this comment.
Is getSettingsDirectory() now a recommended way to get a project root dir?
Could project.getRootProject().getRootDir() be used here?
There was a problem hiding this comment.
Yes. In general accessing other projects from a project should be avoided. Gradle is more forgiving for rootProject but still not ideal.
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 27, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 27, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid eager task creation introduced lately that seems to trigger some wrong behaviour here.
Also use newer api for resolving root project