Improve randomIdentifier usage in AWS tests
#125775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds prefixes to various randomly-generated values to make it easier to pin down where they're coming from in debugging sessions. Also forces the STS expiry time to be rendered in UTC.
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DiannaHohensee
approved these changes
Mar 27, 2025
| } | ||
|
|
||
| private String generateAndGet() { | ||
| final var newRegion = "test-region-" + ESTestCase.randomIdentifier(); |
There was a problem hiding this comment.
could prefix something additional like "random-test-region-" or "dynamic-test-region-", if you want to make this a little more identifiable/unique that it comes from this class -- as opposed to a random test file generating its own test region where we'll likely to use the same prefix.
| return; | ||
| } | ||
| final var accessKey = randomIdentifier(); | ||
| // ATIA for a test key, similar to AKIA and ASIA used in real AWS credentials |
There was a problem hiding this comment.
So ATIA is not typical for AWS credentials, so this is more visible? Add something saying ATIA deliberately differs for identifiability?
Or just prefix 'test' or 'access-key-sts' -- ACCESS_KEY_STS_<>. There are no requirements for the access key, right? We just want to be able to read what the random string represents, IIUC.
| sessionToken, | ||
| randomSecretKey(), | ||
| ZonedDateTime.now().plusDays(1L).format(DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ssZ")), | ||
| ZonedDateTime.now(Clock.systemUTC()).plusDays(1L).format(DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ssZ")), |
DaveCTurner
added
auto-merge-without-approval
|
Thanks yeah applied some changes. Doesn't really matter what the prefixes are as long as you can search for them. |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 28, 2025
Adds prefixes to various randomly-generated values to make it easier to pin down where they're coming from in debugging sessions. Also forces the STS expiry time to be rendered in UTC.
💚 Backport successful
|
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Adds prefixes to various randomly-generated values to make it easier to pin down where they're coming from in debugging sessions. Also forces the STS expiry time to be rendered in UTC.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 31, 2025
Adds prefixes to various randomly-generated values to make it easier to pin down where they're coming from in debugging sessions. Also forces the STS expiry time to be rendered in UTC. Co-authored-by: Rene Groeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds prefixes to various randomly-generated values to make it easier to
pin down where they're coming from in debugging sessions. Also forces
the STS expiry time to be rendered in UTC.