Use a custom cache record for CityResponse #125806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Actually, though, for those following along at home, while this is 10x better, it's still absurdly wasteful, since we're not doing any deduplication of low cardinality Strings: 
I'll add a follow up PR where we'll do even better. |
💚 Backport successful
|
|
Related to #96116. |
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Mar 28, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 28, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #125527
I figured I'd run some heap dumps to put actual numbers on my 10x claim from #125527. Anyway, this version really does decrease the size of the objects in memory by almost precisely 10x.
Before:
After:
