Skip to content

Conversation

@mark-vieira
Copy link
Contributor

Converts :x-pack:plugin:ent-search to new cluster framework. Also folds the :qa:rest project into the main project for simplicity.

@mark-vieira mark-vieira added >test Issues or PRs that are addressing/adding tests :Delivery/Build Build or test infrastructure >refactoring auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 labels Mar 27, 2025
@elasticsearchmachine elasticsearchmachine added v9.1.0 Team:Delivery Meta label for Delivery team labels Mar 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

}

tasks.named("yamlRestTest") {
usesDefaultDistribution("uses the xpack/usage api")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to kill our ability to use the integ-test distribution. I've already hit more than one of these.

@rjernst Is there a way we could refactor XpackUsageFeatureAction such that these things are picked up when plugins register them rather than keeping a hard-coded list of them? We allow overriding this in internal cluster tests I assume specifically becuase this is a pain but there's no such way to do that for rest tests. This basically means any project that has a test that relies on the usage api cannot use the integ-test distribution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The way is to make xpack core actually extensible (it claims so now, but has no extensions). I can try to work this out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same issues exists with the "info" API here.

@mark-vieira mark-vieira merged commit 3ac0c13 into elastic:main Mar 28, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.18 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts
9.0

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125807

mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Mar 28, 2025
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Mar 28, 2025
…5807)

(cherry picked from commit 3ac0c13)

# Conflicts:
#	x-pack/plugin/ent-search/qa/rest/build.gradle
@mark-vieira
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x
8.18

Questions ?

Please refer to the Backport tool documentation

mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Mar 28, 2025
…5807)

(cherry picked from commit 3ac0c13)

# Conflicts:
#	x-pack/plugin/ent-search/qa/rest/build.gradle
elasticsearchmachine pushed a commit that referenced this pull request Mar 28, 2025
) (#125878)

* Convert enterprise search module to new testing framework (#125807)

(cherry picked from commit 3ac0c13)

# Conflicts:
#	x-pack/plugin/ent-search/qa/rest/build.gradle

* Fix task name
elasticsearchmachine pushed a commit that referenced this pull request Mar 28, 2025
…5807) (#125879)

* Convert enterprise search module to new testing framework (#125807)

(cherry picked from commit 3ac0c13)

# Conflicts:
#	x-pack/plugin/ent-search/qa/rest/build.gradle

* Fix task name
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Delivery/Build Build or test infrastructure >refactoring Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants