-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Convert enterprise search module to new testing framework #125807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert enterprise search module to new testing framework #125807
Conversation
|
Pinging @elastic/es-delivery (Team:Delivery) |
| } | ||
|
|
||
| tasks.named("yamlRestTest") { | ||
| usesDefaultDistribution("uses the xpack/usage api") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to kill our ability to use the integ-test distribution. I've already hit more than one of these.
@rjernst Is there a way we could refactor XpackUsageFeatureAction such that these things are picked up when plugins register them rather than keeping a hard-coded list of them? We allow overriding this in internal cluster tests I assume specifically becuase this is a pain but there's no such way to do that for rest tests. This basically means any project that has a test that relies on the usage api cannot use the integ-test distribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The way is to make xpack core actually extensible (it claims so now, but has no extensions). I can try to work this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same issues exists with the "info" API here.
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Converts
:x-pack:plugin:ent-searchto new cluster framework. Also folds the:qa:restproject into the main project for simplicity.