Skip to content

Adding changelog for PR 116712 #125810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Adding changelog for PR 116712 #125810

wants to merge 11 commits into from

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Mar 27, 2025 •
edited by mayya-sharipova
Loading

Adding changelog for PR 116712

Relates to #116712

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 labels Mar 27, 2025
@mayya-sharipova mayya-sharipova added :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC >non-issue and removed needs:triage Requires assignment of a team area label labels Mar 31, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Mar 31, 2025
@brianseeders
Copy link
Contributor

I updated the area fields here as they weren't valid values before. Do these seem reasonable?

The possible options are here: https://github.com/elastic/elasticsearch/blob/main/build-tools-internal/src/main/resources/changelog-schema.json

@slobodanadamovic slobodanadamovic self-requested a review April 2, 2025 10:53
@slobodanadamovic
Copy link
Contributor

I updated the area fields here as they weren't valid values before. Do these seem reasonable?

The possible options are here: https://github.com/elastic/elasticsearch/blob/main/build-tools-internal/src/main/resources/changelog-schema.json

These look fine to me. Thanks for updating.

slobodanadamovic
slobodanadamovic reviewed Apr 2, 2025
View reviewed changes
@slobodanadamovic slobodanadamovic added the >docs General docs changes label Apr 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Apr 2, 2025
@slobodanadamovic
Copy link
Contributor

@cauemarcondes I left couple of suggestion. Feel free to incorporate them as you wish. I would also suggest to ping someone from es-docs team to take a look as well.

cauemarcondes and others added 3 commits April 3, 2025 11:52
@cauemarcondes @slobodanadamovic
Update docs/changelog/116712.yaml
9178802 
Co-authored-by: Slobodan Adamović <[email protected]>
@cauemarcondes @slobodanadamovic
Update docs/changelog/116712.yaml
6bfe489 
Co-authored-by: Slobodan Adamović <[email protected]>
@cauemarcondes @slobodanadamovic
Update docs/changelog/116712.yaml
32a1a2d 
Co-authored-by: Slobodan Adamović <[email protected]>
leemthompo
leemthompo reviewed Apr 3, 2025
View reviewed changes
@cauemarcondes cauemarcondes requested a review from leemthompo April 3, 2025 19:49
slobodanadamovic
slobodanadamovic reviewed Apr 4, 2025
View reviewed changes
slobodanadamovic
slobodanadamovic approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@slobodanadamovic slobodanadamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cauemarcondes cauemarcondes removed the request for review from leemthompo April 4, 2025 16:50
@cauemarcondes cauemarcondes enabled auto-merge (squash) April 4, 2025 16:50
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/core-docs (Team:Docs)

@leemthompo
Copy link
Contributor

@cauemarcondes @slobodanadamovic looks like this never got merged

@cauemarcondes
Copy link
Contributor Author

wow.. indeed. I totally lost track of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leemthompo leemthompo leemthompo left review comments

@slobodanadamovic slobodanadamovic slobodanadamovic approved these changes

Assignees

No one assigned

Labels

>docs General docs changes >non-issue :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Docs Meta label for docs team Team:Security Meta label for security team v9.0.0 v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cauemarcondes @elasticsearchmachine @brianseeders @slobodanadamovic @leemthompo @mayya-sharipova