-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Revert "Add temporary logging for #125668 (#125749)" #125820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add temporary logging for #125668 (#125749)" #125820
Conversation
This reverts commit 8ced682.
muted-tests.yml
Outdated
| issue: https://github.com/elastic/elasticsearch/issues/125642 | ||
| - class: org.elasticsearch.repositories.blobstore.testkit.analyze.GCSRepositoryAnalysisRestIT | ||
| method: testRepositoryAnalysis | ||
| issue: https://github.com/elastic/elasticsearch/issues/125668 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to un-mute this anyway, any objection if we don't revert this bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my comment maybe ambiguous. I meant it's ok to not revert since this is a much simpler revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errr it got muted again 51ed156 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I haven't got the client revert through the pipeline yet. I probably should have done them in the opposite order (client then logging).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
…lastic#125820) This reverts commit 8ced682.
This reverts commit 8ced682.