[Failure Store] Prevent explicit selectors in role index name patterns #125843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding basic validation to prevent using `::` selectors when defining
index permissions.
For example, the `test-*::failures` will not be allowed for `test-role`:
```
PUT /_security/role/test-role
{
"indices": [
{
"names": ["test-*::failures"],
"privileges": ["read"]
}
]
}
```
slobodanadamovic
added
>non-issue
:Security/Security
| } | ||
| if (DataStream.isFailureStoreFeatureFlagEnabled()) { | ||
| for (String indexName : ridp.indicesPrivileges().getIndices()) { | ||
| validationException = validateIndexNameExpression(indexName, validationException); |
There was a problem hiding this comment.
We don't support failure store privileges yet for RCS2, but I think we should prevent using :: in remote index patterns as well - regardless of the privileges support.
|
Pinging @elastic/es-security (Team:Security) |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Mar 31, 2025
elastic#125843) Adding basic validation to prevent using `::` selectors when defining index permissions. Index names do not allow colon character (`:`), hence the index name patterns that would include double colon (`::`), would never match any of the index names. To avoid confusion, we are preventing using `::` in role index name patterns. For example, the `test-*::failures` will be rejected during `test-role` validation: ``` PUT /_security/role/test-role { "indices": [ { "names": ["test-*::failures"], "privileges": ["read"] } ] } ``` (cherry picked from commit 1f7e26c)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 31, 2025
#125843) (#125939) Adding basic validation to prevent using `::` selectors when defining index permissions. Index names do not allow colon character (`:`), hence the index name patterns that would include double colon (`::`), would never match any of the index names. To avoid confusion, we are preventing using `::` in role index name patterns. For example, the `test-*::failures` will be rejected during `test-role` validation: ``` PUT /_security/role/test-role { "indices": [ { "names": ["test-*::failures"], "privileges": ["read"] } ] } ``` (cherry picked from commit 1f7e26c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding basic validation to prevent using
::selectors when defining index permissions.Index names do not allow colon character (
:), hence the index name patterns thatwould include double colon (
::), would never match any of the index names.To avoid confusion, we are preventing using
::in role index name patterns.For example, the
test-*::failureswill be rejected duringtest-rolevalidation: