Skip to content

Conversation

@smalyshev
Copy link
Contributor

My theory is that only testStopQueryLocal is actually broken, and the other tests fail because of the fallout. Try to unmute them while testStopQueryLocal is muted and verify this theory.

@smalyshev smalyshev added :Search Foundations/Search Catch all for Search Foundations v9.1.0 >test Issues or PRs that are addressing/adding tests labels Mar 29, 2025
@smalyshev smalyshev marked this pull request as ready for review March 29, 2025 01:53
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Mar 29, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Copy link
Contributor

@drempapis drempapis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, eventually, ci will prove the hypothesis in the description.

@smalyshev smalyshev enabled auto-merge (squash) March 31, 2025 13:58
@smalyshev smalyshev merged commit 242a195 into elastic:main Mar 31, 2025
17 checks passed
@smalyshev smalyshev deleted the unmute-stop branch March 31, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants