Support explicit Z/M attributes using WKT geometry #125896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.1.0
external-contributor
omricohenn
changed the title
omricohenn
changed the title
Contributor
Author
|
@iverase Hi, here is a new PR that adds explicit Z/M dimensionality support for all geometry types. I'd appreciate your review when you have time. |
mayya-sharipova
added
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
Contributor
|
@elasticmachine ok to test |
Contributor
|
@elasticmachine test this please |
iverase
reviewed
Apr 3, 2025
Contributor
iverase
left a comment
iverase
left a comment
There was a problem hiding this comment.
I triggered test on the PR, it is looking good, I like the simplicity of the approach, thanks!
Contributor
|
ci complains about this: |
Contributor
|
@elasticmachine test this please |
Contributor
Author
|
@iverase thanks! added fix to handle EOF, could you take a look and rerun CI please? |
Contributor
|
CI is running. I added manually the changelog file. |
Contributor
|
@elasticmachine test this please |
iverase
approved these changes
Apr 3, 2025
Contributor
|
Thank you @omricohenn ! |
Contributor
Author
|
cool, thanks for the quick review @iverase ! |
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for explicit 'Z' and 'M' dimensionality declarations in WKT geometry types according to OGC Simple Features standard. When 'Z' or 'M' is specified for any geometry type (Point, LineString, Polygon, etc.), three coordinates are now required. The parser validates this requirement and throws appropriate exceptions with clear error messages when insufficient coordinates are provided. Comprehensive tests have been added for all relevant geometry types. (#123111)