Return null from transformer when not transforming #125961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transform API for instrumentation should return null when no transformation occurs. This commit fixes our entitlement transformer to return null instead of the original buffer. closesn elastic#125920
rjernst
added
>non-issue
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@elasticmachine update branch |
This was referenced Mar 31, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 31, 2025
The transform API for instrumentation should return null when no transformation occurs. This commit fixes our entitlement transformer to return null instead of the original buffer. closes elastic#125920
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 31, 2025
The transform API for instrumentation should return null when no transformation occurs. This commit fixes our entitlement transformer to return null instead of the original buffer. closes elastic#125920
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 31, 2025
The transform API for instrumentation should return null when no transformation occurs. This commit fixes our entitlement transformer to return null instead of the original buffer. closes elastic#125920
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 31, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 31, 2025
rjernst
added a commit
that referenced
this pull request
Mar 31, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Apr 1, 2025
The transform API for instrumentation should return null when no transformation occurs. This commit fixes our entitlement transformer to return null instead of the original buffer. closes elastic#125920
jozala
pushed a commit
to jozala/elasticsearch
that referenced
this pull request
Apr 1, 2025
The transform API for instrumentation should return null when no transformation occurs. This commit fixes our entitlement transformer to return null instead of the original buffer. closes elastic#125920
jozala
added a commit
that referenced
this pull request
Apr 1, 2025
The transform API for instrumentation should return null when no transformation occurs. This commit fixes our entitlement transformer to return null instead of the original buffer. Co-authored-by: Ryan Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transform API for instrumentation should return null when no transformation occurs. This commit fixes our entitlement transformer to return null instead of the original buffer.
closes #125920