Ensure the set of remote clusters is consistent over the life of ES|QL query #126000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalyshev
added
:Analytics/ES|QL
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
dnhatn
approved these changes
Apr 2, 2025
| /** | ||
| * Returns a set of currently configured remote clusters. | ||
| */ | ||
| default Set<String> getConfiguredClusters() { |
There was a problem hiding this comment.
Can we avoid the default implementation here?
There was a problem hiding this comment.
We could but it would make some tests a lot more verbose.
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Apr 2, 2025
…L query (elastic#126000) * Ensure the set of remote clusters is consistent over the life of ES|QL query (cherry picked from commit d84b65d) # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
…L query (elastic#126000) * Ensure the set of remote clusters is consistent over the life of ES|QL query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the configuration changes in the middle of the query, we should use the same set of clusters throughout. This avoids various race conditions and eliminates the need for repeated resolution.