Add time bucket to time-series rate aggregation #126010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
add-range-to-rate
branch
4 times, most recently
from
e975a0e to
1d9543d
Compare
dnhatn
changed the title
dnhatn
force-pushed
the
add-range-to-rate
branch
from
1d9543d to
2746d98
Compare
dnhatn
force-pushed
the
add-range-to-rate
branch
from
2746d98 to
e972f91
Compare
dnhatn
added
>non-issue
:Analytics/ES|QL
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Apr 4, 2025
|
|
||
| public TimeSeriesAggregate(StreamInput in) throws IOException { | ||
| super(in); | ||
| this.timeBucket = in.readOptionalWriteable(inp -> (Bucket) Bucket.ENTRY.reader.read(inp)); |
Contributor
There was a problem hiding this comment.
Does this need to be versioned?
Member
Author
There was a problem hiding this comment.
I disabled time_series tests in mixed clusters to allow us to move quickly here.
kkrik-es
approved these changes
Apr 4, 2025
Member
Author
|
Thanks Kostas! |
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
We need the bucket interval within the rate function to perform extrapolation. With this change, along with elastic#26089, we will be able to pass the grouping range interval to rate aggregations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the bucket interval within the rate function to perform extrapolation. With this change, along with #26089, we will be able to pass the grouping range interval to rate aggregations.