Data stream options convert to javaRestTests to yamlRestTests.
#126037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>test
elasticsearchmachine
added
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Member
PeteGillinElastic
left a comment
PeteGillinElastic
left a comment
There was a problem hiding this comment.
LGTM, except that there's one test which I think we might want to add. Other than that, just a few nits in comments or text (I'm guessing from copy-and-paste errors... I thought that was my speciality!).
.../yamlRestTest/resources/rest-api-spec/test/data_stream/220_failure_store_cluster_setting.yml
Outdated
Show resolved
Hide resolved
.../yamlRestTest/resources/rest-api-spec/test/data_stream/220_failure_store_cluster_setting.yml
Outdated
Show resolved
Hide resolved
.../yamlRestTest/resources/rest-api-spec/test/data_stream/220_failure_store_cluster_setting.yml
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/api/indices.delete_data_stream_options.json
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/api/indices.put_data_stream_options.json
Outdated
Show resolved
Hide resolved
gmarouli
commented
Apr 2, 2025
| '^cat.snapshots/*/*', | ||
| '^cluster.desired_balance/10_basic/*', | ||
| '^data_stream/40_supported_apis/Verify shard stores api', // uses _shard_stores API | ||
| '^data_stream/230_data_stream_options.yml', // updating data stream options does not yet support multi project |
Contributor
Author
There was a problem hiding this comment.
I will make data stream options support multi-project in a follow up PR to keep this within scope.
Contributor
Author
Oh no, I cannot say that you are the only specialist :p. Thanks for being vigilant and helping find them. |
PeteGillinElastic
approved these changes
Apr 2, 2025
Member
PeteGillinElastic
left a comment
PeteGillinElastic
left a comment
There was a problem hiding this comment.
Looks like this is all done now... LGTM when you're ready.
gmarouli
added
auto-merge-without-approval
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Apr 2, 2025
…lastic#126037) In this PR we introduce the data stream API in the `es-rest-api` using the feature flag feature. This enabled us to use the `yamlRestTests` tests instead of the `javaRestTests`. (cherry picked from commit 2505049) # Conflicts: # x-pack/qa/multi-project/core-rest-tests-with-multiple-projects/build.gradle
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 2, 2025
…126037) (#126142) In this PR we introduce the data stream API in the `es-rest-api` using the feature flag feature. This enabled us to use the `yamlRestTests` tests instead of the `javaRestTests`. (cherry picked from commit 2505049) # Conflicts: # x-pack/qa/multi-project/core-rest-tests-with-multiple-projects/build.gradle
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
…lastic#126037) In this PR we introduce the data stream API in the `es-rest-api` using the feature flag feature. This enabled us to use the `yamlRestTests` tests instead of the `javaRestTests`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we introduce the data stream API in the
es-rest-apiusing the feature flag feature. This enabled us to use theyamlRestTeststests instead of thejavaRestTests.