ES|QL: enable generative tests #126097
Merged
ES|QL: enable generative tests #126097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>test
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
reviewed
Apr 2, 2025
| result.append(randomName(previousOutput)); | ||
| String fieldName = randomRawName(previousOutput); | ||
| if (fieldName.isEmpty()) { // it's a bug, managed later, skipping for now | ||
| randomAlphaOfLength(5); |
Contributor
There was a problem hiding this comment.
Should this assign to a fieldName?
If so consider using randomIdentifier() instead.
Contributor
Author
There was a problem hiding this comment.
Aaahhh, automerged too quickly...
Yeah, it should assign to fieldName
idegtiarenko
approved these changes
Apr 2, 2025
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to enable tests that generate random queries.
Only single node for now. If it's not too noisy we'll also have to enable it in multi-node.