Fix for [CI] ReindexDataStreamTransportActionIT testAlready… #126123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewhiting
added
>test
elasticsearchmachine
added
the
needs:triage
lukewhiting
added
>test-failure
elasticsearchmachine
added
needs:triage
lukewhiting
added
>test
elasticsearchmachine
added
the
needs:triage
lukewhiting
added
the
:Data Management/Data streams
elasticsearchmachine
added
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
…UpToDateDataStream failing
lukewhiting
force-pushed
the
es-125727-testfail-testAlreadyUpToDateDataStream
branch
from
0d904a6 to
85d1a1e
Compare
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
lukewhiting
added a commit
to lukewhiting/elasticsearch
that referenced
this pull request
Apr 2, 2025
…UpToDateDataStream failing (elastic#126123) (cherry picked from commit d816845) # Conflicts: # muted-tests.yml
lukewhiting
added a commit
to lukewhiting/elasticsearch
that referenced
this pull request
Apr 2, 2025
…UpToDateDataStream failing (elastic#126123) (cherry picked from commit d816845) # Conflicts: # muted-tests.yml
lukewhiting
added a commit
to lukewhiting/elasticsearch
that referenced
this pull request
Apr 2, 2025
…UpToDateDataStream failing (elastic#126123) (cherry picked from commit d816845) # Conflicts: # muted-tests.yml
lukewhiting
added a commit
to lukewhiting/elasticsearch
that referenced
this pull request
Apr 2, 2025
…UpToDateDataStream failing (elastic#126123) (cherry picked from commit d816845) # Conflicts: # muted-tests.yml
lukewhiting
added a commit
to lukewhiting/elasticsearch
that referenced
this pull request
Apr 2, 2025
…UpToDateDataStream failing (elastic#126123) (cherry picked from commit d816845) # Conflicts: # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
This was referenced Apr 2, 2025
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
…UpToDateDataStream failing (elastic#126123)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there's a race condition here where we check if the newly created reindex is complete before the task framework has had a chance to work out that it's a noop.
I wrapped the assertions in an assertBusy block and that seems to have resolved the intermittent fails.
Based on 1000 local iterations with random seeds:
Fail rate before fix: 3-5%
Fail rate after fix: 0%
Fixes #125727