Acquire searcher in field caps only when needed #126137
Conversation
FieldCapabilitiesFetcher acquires a searcher to perform basic checks that don't actually require a searcher to be performed, as they are purely mappings driven. Instead, we can reuse the existing QueryRewriteContext to perform such checks and entirely avoid acquiring a searcher.
javanna
added
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
| final Engine.Searcher searcher; | ||
| if (alwaysMatches(indexFilter)) { | ||
| // no need to open a searcher if we aren't filtering, but make sure we are reading from an up-to-dated shard | ||
| indexShard.readAllowed(); |
There was a problem hiding this comment.
I am not sure what the purpose of this is, I think we can drop it as well, can't we?
|
|
||
| public boolean hasMappings() { | ||
| return mappingLookup.hasMappings(); | ||
| } |
There was a problem hiding this comment.
these methods rely on state that's already available in query rewrite context, there's no good reason to expose them only in SearchExecutionContext, that's more of a leftover from before we were able to rewrite based on mappings only.
javanna
changed the title
javanna
changed the title
javanna
changed the title
|
Hi @javanna, I've created a changelog YAML for you. |
| if (searcher != null && canMatchShard(shardId, indexFilter, nowInMillis, searchExecutionContext) == false) { | ||
| QueryRewriteContext queryRewriteContext = indexService.newQueryRewriteContext(() -> nowInMillis, runtimeFields, null); | ||
| var indexMode = indexService.getIndexSettings().getMode(); | ||
| if (canMatchShard(shardId, indexFilter, nowInMillis, queryRewriteContext) == false) { |
There was a problem hiding this comment.
here is what I missed: while this method takes a query rewrite context, it can indirectly call convertToSearchExecutionContext which performs additional actions, and only does something when the original argument was a SearchExecutionContext. That means a searcher may be needed, but not necessarily.
2 participants
FieldCapabilitiesFetcher acquires a searcher to perform basic checks that don't actually require a searcher to be performed, as they are purely mappings driven. Instead, we can reuse the existing QueryRewriteContext to perform such checks and entirely avoid acquiring a searcher.