Put the not-entitled message in the log (#126072) #126162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
backport
auto-merge-without-approval
This was referenced Apr 2, 2025
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Apr 2, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 2, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #126072.
The not-entitled message text appears as the message in the
NotEntitledException, so to avoid redundancy, I removed it from the log message here. However, this makes it awkward to generate concise alert messages.Let's put the not-entitled message back in the log, redundant though that may be, to help us compose good alert messages.
See ES-10968.