Some cleanups to counting in AbstractSearchAsyncAction #126167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With batched execution merged, turns out we can inline one single-use method here and deduplicate the counting to zero as well.
original-brownbear
added
>non-issue
:Search Foundations/Search
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
the
Team:Search Foundations
|
|
||
| private void onShardResultConsumed() { | ||
| successfulOps.incrementAndGet(); | ||
| // we need to increment successful ops first before we compare the exit condition otherwise if we |
Contributor
Author
There was a problem hiding this comment.
This comment makes no sense at this point, there is no total ops counter anymore.
benchaplin
approved these changes
Apr 21, 2025
Contributor
benchaplin
left a comment
benchaplin
left a comment
There was a problem hiding this comment.
Nice cleanups and consolidating some duplicate code. Just one minor question.
server/src/main/java/org/elasticsearch/action/search/AbstractSearchAsyncAction.java
Show resolved
Hide resolved
Contributor
Author
|
Thanks Ben! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With batched execution merged, turns out we can inline one single-use method here and deduplicate the counting to zero as well.
Also, this removes a completely outdated comment that doesn't apply anymore since we only use the outstanding ops counter.