Adjust method to transition split state #126179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
added
>non-issue
:Distributed Indexing/Distributed
elasticsearchmachine
added
the
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
elasticsearchmachine
added
the
serverless-linked
bcully
reviewed
Apr 3, 2025
server/src/main/java/org/elasticsearch/cluster/metadata/IndexReshardingMetadata.java
Show resolved
Hide resolved
Comment on lines
221
to
224
| IndexReshardingState.Split.TargetShardState[] newTargets = Arrays.copyOf( | ||
| splitState.targetShards(), | ||
| splitState.targetShards().length | ||
| ); |
There was a problem hiding this comment.
Maybe we should make a builder to centralize the logic for creating a new state instead of mutating the existing one?
There was a problem hiding this comment.
I think you had already created one that I wasn't using. I just switched to that.
server/src/main/java/org/elasticsearch/cluster/metadata/IndexReshardingMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/IndexReshardingState.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the method to transition to handoff be generic and support multiple
states.