Skip to content

[8.x] Fix CommonPrefixes rendering in S3HttpHandler (#126147) #126181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

[8.x] Fix CommonPrefixes rendering in S3HttpHandler (#126147) #126181

merged 1 commit into from
Apr 3, 2025
+21 −6

Conversation

DaveCTurner
Copy link
Contributor

Backports the following commits to 8.x:

@DaveCTurner
Fix CommonPrefixes rendering in S3HttpHandler (elastic#126147)
e7df3dd 
Today the `ListObjects` implementation in `S3HttpHandler` will put all
the common prefixes in a single `<CommonPrefixes>` container, but in
fact the real S3 gives each one its own container. The v1 SDK is lenient
and accepts either, but the v2 SDK requires us to do this correctly.
This commit fixes the test fixture to match the behaviour of the real
S3.
@DaveCTurner DaveCTurner added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed Coordination Meta label for Distributed Coordination team labels Apr 3, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Apr 3, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit bf3fee4 into elastic:8.x Apr 3, 2025
15 checks passed
@DaveCTurner DaveCTurner deleted the backport/8.x/pr-126147 branch April 3, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v8.19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DaveCTurner @elasticsearchmachine