Skip to content

Fix TsdbDocValueBwcTests test failure. #126182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Fix TsdbDocValueBwcTests test failure. #126182

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8451909
Fix TsdbDocValueBwcTests test failure.
martijnvg Apr 3, 2025
8000d52
[CI] Auto commit changes from spotless
Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions server/src/test/java/org/elasticsearch/index/codec/tsdb/TsdbDocValueBwcTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,15 @@ private IndexWriterConfig getTimeSeriesIndexWriterConfig(String hostnameField, S

// A hacky way to figure out whether doc values format is written in what version. Need to use reflection, because
// PerFieldDocValuesFormat hides the doc values formats it wraps.
private static void assertOldDocValuesFormatVersion(DirectoryReader reader) throws NoSuchFieldException, IllegalAccessException,
IOException {
private void assertOldDocValuesFormatVersion(DirectoryReader reader) throws NoSuchFieldException, IllegalAccessException, IOException {
if (System.getSecurityManager() != null) {
// With jvm version 24 entitlements are used and security manager is nog longer used.
// Making this assertion work with security manager requires granting the entire test codebase privileges to use
// suppressAccessChecks and accessDeclaredMembers. This is undesired from a security manager perspective.
logger.info("not asserting doc values format version, because security manager is used");
return;
}

for (var leafReaderContext : reader.leaves()) {
var leaf = (SegmentReader) leafReaderContext.reader();
var dvReader = leaf.getDocValuesReader();
Expand All @@ -248,8 +255,16 @@ private static void assertOldDocValuesFormatVersion(DirectoryReader reader) thro
}
}

private static void assertNewDocValuesFormatVersion(DirectoryReader reader) throws NoSuchFieldException, IllegalAccessException,
IOException, ClassNotFoundException {
private void assertNewDocValuesFormatVersion(DirectoryReader reader) throws NoSuchFieldException, IllegalAccessException, IOException,
ClassNotFoundException {
if (System.getSecurityManager() != null) {
// With jvm version 24 entitlements are used and security manager is nog longer used.
// Making this assertion work with security manager requires granting the entire test codebase privileges to use
// suppressAccessChecks and suppressAccessChecks. This is undesired from a security manager perspective.
logger.info("not asserting doc values format version, because security manager is used");
return;
}

for (var leafReaderContext : reader.leaves()) {
var leaf = (SegmentReader) leafReaderContext.reader();
var dvReader = leaf.getDocValuesReader();
Expand Down