Data stream lifecycle does not record error in failure store rollover #126229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>non-issue
:Data Management/Data streams
elasticsearchmachine
added
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
gmarouli
added
the
auto-merge-without-approval
gmarouli
deleted the
fix/dlm-does-not-record-failure-store-rollover-error
branch
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Apr 4, 2025
…elastic#126229) **Issue** The data stream lifecycle does not register correctly rollover errors for failure store. **Observed bahaviour** When data stream lifecycle encounters a rollover error it records it unless it sees that the current write index of this data stream doesn't match the source index of the request. However, the write index check does not use the failure write index but the write backing index, so the failure gets ignored **Desired behaviour** When data stream lifecycle encounters a rollover error it will check the relevant write index before it determines if it should be recorded or not. (cherry picked from commit 488951e) # Conflicts: # modules/data-streams/src/internalClusterTest/java/org/elasticsearch/datastreams/lifecycle/ExplainDataStreamLifecycleIT.java # modules/data-streams/src/main/java/org/elasticsearch/datastreams/lifecycle/DataStreamLifecycleService.java
gmarouli
added a commit
that referenced
this pull request
Apr 4, 2025
…llover (#126229) (#126269) * Data stream lifecycle does not record error in failure store rollover (#126229) **Issue** The data stream lifecycle does not register correctly rollover errors for failure store. **Observed bahaviour** When data stream lifecycle encounters a rollover error it records it unless it sees that the current write index of this data stream doesn't match the source index of the request. However, the write index check does not use the failure write index but the write backing index, so the failure gets ignored **Desired behaviour** When data stream lifecycle encounters a rollover error it will check the relevant write index before it determines if it should be recorded or not. (cherry picked from commit 488951e) # Conflicts: # modules/data-streams/src/internalClusterTest/java/org/elasticsearch/datastreams/lifecycle/ExplainDataStreamLifecycleIT.java # modules/data-streams/src/main/java/org/elasticsearch/datastreams/lifecycle/DataStreamLifecycleService.java * Fix test to anticipate force merge error
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
…elastic#126229) **Issue** The data stream lifecycle does not register correctly rollover errors for failure store. **Observed bahaviour** When data stream lifecycle encounters a rollover error it records it unless it sees that the current write index of this data stream doesn't match the source index of the request. However, the write index check does not use the failure write index but the write backing index, so the failure gets ignored **Desired behaviour** When data stream lifecycle encounters a rollover error it will check the relevant write index before it determines if it should be recorded or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The data stream lifecycle does not register correctly rollover errors for failure store.
Observed bahaviour
When data stream lifecycle encounters a rollover error it records it unless it sees that the current write index of this data stream doesn't match the source index of the request. However, the write index check does not use the failure write index but the write backing index, so the failure gets ignored
Desired behaviour
When data stream lifecycle encounters a rollover error it will check the relevant write index before it determines if it should be recorded or not.