Cleanup community_id processor #126247
Merged
Cleanup community_id processor #126247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to silence warnings from IntelliJ.
to quiet a warning from IntelliJ.
joegallo
added
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
reviewed
Apr 3, 2025
| try { | ||
| output = processor.execute(input); | ||
| } catch (Exception e) { | ||
| throw ExceptionsHelper.convertToRuntime(e); |
Member
There was a problem hiding this comment.
I did not realize until this moment that ExceptionsHelper.convertToRuntime was compatible with expectThrows.
masseyke
approved these changes
Apr 3, 2025
joegallo
added
the
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a refactoring PR. I'm in this code because of other PRs, and there's just a bunch of things that I can't ignore.
This really is just code tidying, if CI approves then you probably should, too; but you're cordially invited to go through it with a fine-toothed comb.