Skip to content

[8.x] Support ListObjectsV2 in S3HttpHandler (#126189) #126268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

[8.x] Support ListObjectsV2 in S3HttpHandler (#126189) #126268

merged 1 commit into from
Apr 4, 2025

Conversation

@DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Apr 4, 2025

Backports the following commits to 8.x:

@DaveCTurner
Support ListObjectsV2 in S3HttpHandler (elastic#126189)
3f3fdea 
`ListObjects` and `ListObjectsV2` only really differ in their approach
to pagination, but today `S3HttpHandler` does not simulate pagination
anyway so we can use the same handling code for both APIs. The only
practical difference is that the v2 SDK requires the `<IsTruncated>`
element in a `ListObjectsV2` response, but this element is permitted in
both APIs so we add it here.
@DaveCTurner DaveCTurner added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed Coordination Meta label for Distributed Coordination team labels Apr 4, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Apr 4, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit 8d54069 into elastic:8.x Apr 4, 2025
15 checks passed
@DaveCTurner DaveCTurner deleted the backport/8.x/pr-126189 branch April 4, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v8.19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DaveCTurner @elasticsearchmachine