Extrapolate rate aggregation #126331
Merged
Extrapolate rate aggregation #126331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
keep-rate-sample
branch
4 times, most recently
from
9e182cd to
9f24510
Compare
dnhatn
commented
Apr 7, 2025
| return new DriverContext(blockFactory.bigArrays(), blockFactory); | ||
| } | ||
|
|
||
| public void testBasicRate() throws Exception { |
Member
Author
There was a problem hiding this comment.
We no longer need these tests. Spec tests should cover them.
dnhatn
added
:Analytics/ES|QL
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Apr 7, 2025
...mpute/src/main/generated-src/org/elasticsearch/compute/aggregation/RateDoubleAggregator.java
Show resolved
Hide resolved
kkrik-es
reviewed
Apr 7, 2025
...mpute/src/main/generated-src/org/elasticsearch/compute/aggregation/RateDoubleAggregator.java
Show resolved
Hide resolved
kkrik-es
reviewed
Apr 7, 2025
...mpute/src/main/generated-src/org/elasticsearch/compute/aggregation/RateDoubleAggregator.java
Show resolved
Hide resolved
kkrik-es
reviewed
Apr 7, 2025
...mpute/src/main/generated-src/org/elasticsearch/compute/aggregation/RateDoubleAggregator.java
Show resolved
Hide resolved
kkrik-es
reviewed
Apr 7, 2025
Contributor
kkrik-es
left a comment
kkrik-es
left a comment
There was a problem hiding this comment.
Nice, good progress. Do we have tests covering the cases where we have 0 or 1 data points in a bucket?
Member
Author
|
@kkrik-es Thanks for reviewing. I think this is ready again. |
Member
Author
|
@kkrik-es Thanks so much for the quick review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change performs extrapolation for rate aggregation similarly to how PromQL does.