Skip to content

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Apr 4, 2025

To backport the newly introduced AggregateMetricDoubleLiteral to 8.x, we need to override the supportsVersion method instead of getMinimalSupportedVersion.

@dnhatn dnhatn requested review from limotova and nik9000 April 4, 2025 23:05
@dnhatn dnhatn marked this pull request as ready for review April 4, 2025 23:05
@dnhatn dnhatn requested a review from a team as a code owner April 4, 2025 23:05
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@limotova limotova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@dnhatn dnhatn merged commit fbfc707 into elastic:main Apr 5, 2025
16 of 17 checks passed
@dnhatn dnhatn deleted the serialization branch April 5, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants