Pre-size collections #126382
Pre-size collections #126382
Conversation
idegtiarenko
added
>non-issue
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
| } else { | ||
| inputId = ne.id(); | ||
| } | ||
| Map<Integer, Layout.ChannelSet> inputChannelToOutputIds = Maps.newHashMapWithExpectedSize(projections.size()); |
There was a problem hiding this comment.
We aren't using this collection from what I see? We're just doing a .get(), but never adding things
There was a problem hiding this comment.
Good catch, why do we even spend time and resources populating it then?
There was a problem hiding this comment.
I wonder, since that map is not used, does it mean we might duplicate actual data in the actual layout?
There was a problem hiding this comment.
Nice catch!
I think this map is unused for forever now, and people found this redundant map multiple times. I was sure one of the times, we actually had merged the fix...
I'm not sure how the channel sets were intended to be used for project, but the current project operator does shallow copies of blocks, and this works well and is intended. It didn't always do this, we had to first make it work by making blocks refcounted. Maybe before that, the channel sets were supposed to help with deduplication.
4 participants
This pre-sizes collections with wisible resizing cost in profile output.